Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease commands to reduce layers #4

Merged
merged 15 commits into from
Oct 31, 2023
Merged

Decrease commands to reduce layers #4

merged 15 commits into from
Oct 31, 2023

Conversation

alee-ntap
Copy link
Contributor

What this PR does / why we need it:

This PR is combining commands to decrease the amount of layers of the image. And added comment to make it easier to read.

Which issue(s) this PR fixes:
Fixes #1

@gardener-robot
Copy link
Contributor

@alee-ntap Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Oct 27, 2023
@Vincinator
Copy link
Contributor

note: before merging, we need to squash the WIP commits in main

@nanory
Copy link
Contributor

nanory commented Oct 30, 2023

Hi @alee-ntap,
this looks already good but could you do the same also for crossbuild.containerfile so that it's streamlined?

@nanory nanory self-requested a review October 30, 2023 08:36
nanory
nanory suggested changes Oct 30, 2023
View reviewed changes
build.containerfile Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Oct 30, 2023
@nanory nanory mentioned this pull request Oct 30, 2023
Closed
@alee-ntap
Copy link
Contributor Author

Hi @alee-ntap, this looks already good but could you do the same also for crossbuild.containerfile so that it's streamlined?

Ok. Will do.

@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Oct 30, 2023
@alee-ntap alee-ntap force-pushed the decrease-commands branch 4 times, most recently from ccc588b to 7d44fb5 Compare October 30, 2023 13:27
@nanory nanory force-pushed the decrease-commands branch from 7cca640 to dff8f54 Compare October 31, 2023 08:53
@nanory nanory force-pushed the decrease-commands branch from dff8f54 to 2eadedd Compare October 31, 2023 13:43
nanory
nanory approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@nanory nanory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanory nanory merged commit 34a53ac into main Oct 31, 2023
4 checks passed
@nanory nanory deleted the decrease-commands branch October 31, 2023 13:44
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 31, 2023
@nkraetzschmar nkraetzschmar mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanory nanory nanory approved these changes

Assignees
No one assigned
Labels
needs/changes Needs (more) changes needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decrease the amount of Dockerfile commands
4 participants
@alee-ntap @gardener-robot @Vincinator @nanory